-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22280] New property to select preferred key agreement algorithm (backport #5413) #5442
Conversation
* Refs #19921. Implement selection of key agreement. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Change default to ECDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated publisher code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated subscriber code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add new parameter to BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on publisher properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on subscriber properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Improve emplace_back calls. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Use `DH` alias instead of `RSA`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Add new property to communication tests XML profiles. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Configure key agreement on BB test depending on process id. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Remove unused lambda capture. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix failing blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Update versions.md Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8a99a07) # Conflicts: # versions.md
Cherry-pick of 8a99a07 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 3.0.x 2.14.x 2.10.x |
✅ Backports have been created
|
* New property to select preferred key agreement algorithm (#5413) * Refs #19921. Implement selection of key agreement. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Change default to ECDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated publisher code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated subscriber code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add new parameter to BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on publisher properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on subscriber properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Improve emplace_back calls. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Use `DH` alias instead of `RSA`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Add new property to communication tests XML profiles. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Configure key agreement on BB test depending on process id. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Remove unused lambda capture. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix failing blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Update versions.md Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8a99a07) # Conflicts: # versions.md * Fix conflicts. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Change default value to `DH`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4d793f0)
* New property to select preferred key agreement algorithm (#5413) * Refs #19921. Implement selection of key agreement. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Change default to ECDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated publisher code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated subscriber code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add new parameter to BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on publisher properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on subscriber properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Improve emplace_back calls. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Use `DH` alias instead of `RSA`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Add new property to communication tests XML profiles. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Configure key agreement on BB test depending on process id. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Remove unused lambda capture. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix failing blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Update versions.md Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8a99a07) # Conflicts: # versions.md * Fix conflicts. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Change default value to `DH`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4d793f0) # Conflicts: # test/blackbox/common/BlackboxTestsSecurity.cpp # versions.md
* New property to select preferred key agreement algorithm (#5413) * Refs #19921. Implement selection of key agreement. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Change default to ECDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated publisher code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated subscriber code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add new parameter to BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on publisher properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on subscriber properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Improve emplace_back calls. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Use `DH` alias instead of `RSA`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Add new property to communication tests XML profiles. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Configure key agreement on BB test depending on process id. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Remove unused lambda capture. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix failing blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Update versions.md Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8a99a07) # Conflicts: # versions.md * Fix conflicts. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Change default value to `DH`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4d793f0) # Conflicts: # test/blackbox/common/BlackboxTestsSecurity.cpp # versions.md
…) (#5443) * New property to select preferred key agreement algorithm (#5413) * Refs #19921. Implement selection of key agreement. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Change default to ECDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated publisher code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Factor out duplicated subscriber code on BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add new parameter to BB test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on publisher properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Apply new parameter on subscriber properties. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Improve emplace_back calls. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Use `DH` alias instead of `RSA`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Add new property to communication tests XML profiles. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix unit test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Configure key agreement on BB test depending on process id. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19921. Add `AUTO` value to blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Remove unused lambda capture. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22280. Fix failing blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Update versions.md Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8a99a07) # Conflicts: # versions.md * Fix conflicts. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Change default value to `DH`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4d793f0) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Description
DDS security specifies the possibility of selecting the key agreement algorithm used to generate the shared secret at the end of the authentication phase.
The Fast DDS documentation indicates that
Elliptic Curve Diffie-Hellman (ECDH)
is used, but this is only the case if a participant from other vendor starts the authentication and proposes that method.This pull request:
dds.sec.auth.builtin.PKI-DH.preferred_key_agreement
property that allows choosing the preferred algorithm to use.@Mergifyio backport 3.1.x
We will backport to 3.1.x, but leaving the default value of the new property to the old behavior.
We will then backport from there into 3.0.x 2.14.x 2.10.x
Contributor Checklist
versions.md
file (if applicable).preferred_key_agreement
property Fast-DDS-docs#963Reviewer Checklist
This is an automatic backport of pull request #5413 done by [Mergify](https://mergify.com).