-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20707] Migrate BuiltinEndpoints defines to variables #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
elianalf
changed the title
[20707] Migrate BuiltinEndpoints
[20707] Migrate BuiltinEndpoints defines to variables
May 28, 2024
elianalf
suggested changes
May 29, 2024
EduPonz
force-pushed
the
feature/migrate_builtin_endpoints
branch
from
May 30, 2024 13:01
9ed4046
to
d3116b6
Compare
elianalf
approved these changes
May 30, 2024
elianalf
suggested changes
May 30, 2024
EduPonz
force-pushed
the
feature/migrate_builtin_endpoints
branch
from
May 31, 2024 09:13
2699df2
to
633a43f
Compare
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
EduPonz
force-pushed
the
feature/migrate_builtin_endpoints
branch
from
June 3, 2024 05:48
633a43f
to
8314ebb
Compare
elianalf
approved these changes
Jun 3, 2024
EduPonz
added a commit
that referenced
this pull request
Jun 3, 2024
* Refs #20707: Migrate BuiltinEndpoints defines to namespaced constexpr Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20707: Make private additional constants Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20707: Update versions.md Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20707: Apply Eliana's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20707: Rename ParticipantProxyData.h to ParticipantProxyData.hpp Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20707: Uncrustify Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20707: Exclude MockAccessControlPlugin.h from uncrustify Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20707: Fix uncrustify issue in ParticipantDiscoveryInfo.h Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
#define
s inBuiltinEndpoints
to namespaced constextpr .Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist