Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21037] Use %* instead of loop in .bat scripts (backport #4814) #4819

Merged
merged 1 commit into from
May 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 21, 2024

Description

A small improvement that changes the loop populating args variable into using the built-in %*.
See docs here

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4814 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label May 21, 2024
Copy link
Contributor Author

mergify bot commented May 21, 2024

Cherry-pick of 2552fa9 has failed:

On branch mergify/bp/2.13.x/pr-4814
Your branch is up to date with 'origin/2.13.x'.

You are currently cherry-picking commit 2552fa9cd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tools/fastdds/fastdds.bat
	both modified:   tools/fastdds/ros-discovery.bat

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@EduPonz EduPonz added this to the v2.13.5 milestone May 21, 2024
@JesusPoderoso
Copy link
Contributor

This PR needs the following PR to be merged:

Marking it as temporarily blocked

@JesusPoderoso JesusPoderoso added the temporarily-blocked PR must be merged after another one label May 21, 2024
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)
@JesusPoderoso JesusPoderoso force-pushed the mergify/bp/2.13.x/pr-4814 branch from ed6d826 to 08691c6 Compare May 24, 2024 07:19
@JesusPoderoso JesusPoderoso removed conflicts Backport PR wich git cherry pick failed temporarily-blocked PR must be merged after another one labels May 24, 2024
@JesusPoderoso JesusPoderoso self-requested a review May 24, 2024 07:20
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with passed CI

@github-actions github-actions bot added ci-pending PR which CI is running labels May 24, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test windows please test linux

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 27, 2024
@EduPonz EduPonz merged commit 829348f into 2.13.x May 27, 2024
12 of 15 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.13.x/pr-4814 branch May 27, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants