Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20750] Add check for XML API to PR template (backport #4658) #4659

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 4, 2024

Description

This PR adds a check for the PRs to add XML API if needed.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A Changes are ABI compatible.

  • N/A Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4658 done by [Mergify](https://mergify.com).

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)
@JesusPoderoso JesusPoderoso added this to the v2.13.5 milestone Apr 4, 2024
@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Apr 8, 2024
@JesusPoderoso JesusPoderoso self-requested a review April 8, 2024 09:06
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso self-requested a review April 8, 2024 09:07
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Apr 9, 2024
@EduPonz EduPonz merged commit 66e9760 into 2.13.x Apr 17, 2024
7 of 8 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.13.x/pr-4658 branch April 17, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants