Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20391] Migrate communication tests #4290

Merged
merged 10 commits into from
Mar 5, 2024
Merged

[20391] Migrate communication tests #4290

merged 10 commits into from
Mar 5, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jan 24, 2024 •
edited by EduPonz
Loading

Description

This pr migrates test/communication tests into test/dds/communication folder, which use the new APIs rather than the old ones of fastrtps

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jan 24, 2024
@JLBuenoLopez JLBuenoLopez force-pushed the feature/3.0.x branch 5 times, most recently from 22912a5 to 9c63223 Compare January 30, 2024 14:43
@elianalf elianalf changed the title [19452] Migrate communication tests [20340] Migrate communication tests Jan 31, 2024
@elianalf elianalf force-pushed the feature/3.0.x branch 3 times, most recently from ade136b to 51c21ef Compare February 12, 2024 06:59
@JLBuenoLopez JLBuenoLopez force-pushed the feature/3.0.x branch 3 times, most recently from 805ac25 to b382967 Compare February 20, 2024 13:49
@elianalf elianalf changed the title [20340] Migrate communication tests [20391] Migrate communication tests Feb 20, 2024
@elianalf elianalf changed the base branch from feature/3.0.x to master February 20, 2024 15:16
@elianalf elianalf force-pushed the release-v3/migrate_communication_tests branch 3 times, most recently from 3e22fa5 to c5d431c Compare February 21, 2024 08:11
@elianalf elianalf modified the milestones: v3.0.0, v2.14.0 Feb 22, 2024
EduPonz
EduPonz previously approved these changes Feb 29, 2024
View reviewed changes
@elianalf
Refs #20391: Migrate liveliness tests
3d12c2b 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Migrate security tests
bf87950 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Migrate SHM tests
52aab36 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Update pub and sub names
e49ed7f 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Update security participant topic
2d92e85 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Migrate Two publishers tests
1d38c50 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Remove old communication test folder
d1368cc 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Update versions.md file
639939f 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: Migrate Pub/Sub Main in security folder
281eafe 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20391: fix build issues
a38ed09 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the release-v3/migrate_communication_tests branch from 6bd5ea3 to a38ed09 Compare February 29, 2024 07:35
EduPonz
EduPonz approved these changes Feb 29, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz added ci-pending PR which CI is running and removed needs rebase labels Feb 29, 2024
@EduPonz
Copy link

EduPonz commented Feb 29, 2024

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

@EduPonz EduPonz added to-do and removed ci-pending PR which CI is running labels Mar 1, 2024
@EduPonz
Copy link

EduPonz commented Mar 1, 2024

@elianalf I'm afraid we'll need to look into the test failures in the MacOS Jenkins job before we can merge this

@EduPonz
Copy link

EduPonz commented Mar 4, 2024

@richiprosima please test this

@elianalf
Copy link
Contributor Author

elianalf commented Mar 4, 2024

@richiprosima please test mac

@EduPonz EduPonz removed the to-do label Mar 5, 2024
@EduPonz EduPonz merged commit 5bf8326 into master Mar 5, 2024
14 of 17 checks passed
@EduPonz EduPonz deleted the release-v3/migrate_communication_tests branch March 5, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @EduPonz @JesusPoderoso