Add support for FOK & IOC limit orders #15
Merged
+262
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rupurt
force-pushed
the
fill-or-kill-and-immediate-or-cancel-orders
branch
from
01c50e5 to
763b8f7
Compare
rupurt
force-pushed
the
fill-or-kill-and-immediate-or-cancel-orders
branch
3 times, most recently
from
c940af2 to
5bf73b5
Compare
rupurt
force-pushed
the
fill-or-kill-and-immediate-or-cancel-orders
branch
from
5bf73b5 to
d2d7332
Compare
|
Looks good to me! What do you think about using constant-like structures for the time in force values? Something like this |
|
@dvcrn do you mean for the defaults? Do you mind adding an example so I can grok your suggestion a little more. |
|
I guess not so important right now. I'll merge this first and then we can think about it at a later point 👍 Thanks a ton of the contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #14