-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dunstctl rule
error when not providing rule state
#1281
Conversation
Previously showed "line 130: 3: unbound variable" instead of the pretty error message.
dunstctl
Outdated
[ "${state}" = "nope" ] \ | ||
&& die "No valid rule state parameter specified. Please give either 'enable', 'disable' or 'toggle'" | ||
case "${3:-}" in | ||
("disable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the remaining file the opening parenthesis should be removed and the final ;;
for each case should be put an its own line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! However I was basing this style on this same file here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use the same style as the main case
. I didn't touch the other unrelated case
though.
70d9c60
to
e647242
Compare
e647242
to
02a3908
Compare
So the problem was the reference to |
Yes, the first commit just changes |
Thanks 👍🏻 |
The issues comes from using |
Previously showed "line 130: 3: unbound variable" instead of the pretty error message.