Recursive icons: Use min_icon_size and max_icon_size instead of icon_size.
#1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recursive icon lookup used an icon_size rule to scale all icons to this size, but this was a bit limiting in allowing bigger icons for things like album art. To fix this, the old behaviour has been reinstated. The main difference is that icons from a theme (that are searched by icon name) are of the size `min_icon_size`, instead of being of whatever size was found first. ref: dunst-project#1037
Since min_icon_size is used for looking up icons, it should not be 0. That would result in no icons being found.
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
+ Coverage 61.30% 65.41% +4.11%
==========================================
Files 45 46 +1
Lines 7097 7351 +254
==========================================
+ Hits 4351 4809 +458
+ Misses 2746 2542 -204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fwsmit
force-pushed
the
recursive-icons-scaling
branch
from
2f6cdd8 to
ff3d0a2
Compare
fwsmit
force-pushed
the
recursive-icons-scaling
branch
from
ff3d0a2 to
54685f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1037