Add creation time field to GoogleMediaItem and populate the upload time for the media models. #1306

aksingh737 · 2023-11-28T23:20:11Z

No description provided.

…into uploadTimeBug

Add creation time field to GoogleMediaItem and populate the upload time for the media models.

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java

...c/test/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItemTest.java

jzacsh

sorry sent my other comments too early; LGTM, but just leaving you some questions so we can follow this in the future.

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java

...gle/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/MediaMetadata.java

adressed the comments on the changelist

fix tests

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java

...gle/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/MediaMetadata.java

jzacsh · 2023-11-29T22:12:51Z

LGTM! Just resolve the comments however you want. I think if I use "LGTM" button in github it'll mask the comments, so just letting you know here: LGTM!

…ata is corrupted.

...gle/src/main/java/org/datatransferproject/datatransfer/google/media/GoogleMediaExporter.java

...e/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java

...e/src/main/java/org/datatransferproject/datatransfer/google/videos/GoogleVideosExporter.java

...c/test/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItemTest.java

...e/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java

osamahan999

lgtm, just double check with Jonathan that monitor.debug actually logs those messages into where we want it to be logged. From the sound of it though I'd assume the debug logs are only local

…roject into uploadTimeBug

# Conflicts: # extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java

...gle/src/main/java/org/datatransferproject/datatransfer/google/media/GoogleMediaExporter.java

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java

...e/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java

...e/src/main/java/org/datatransferproject/datatransfer/google/videos/GoogleVideosExporter.java

...src/test/java/org/datatransferproject/datatransfer/google/media/GoogleMediaExporterTest.java

...e/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java

...e/src/main/java/org/datatransferproject/datatransfer/google/videos/GoogleVideosExporter.java

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java

aksingh737 and others added 14 commits April 21, 2023 00:56

First changelist description

154e8ec

Merge remote-tracking branch 'origin/master' into master-dtp

1ab1f67

Merge remote-tracking branch 'upstream/master' into master-dtp

13fcba5

Merge remote-tracking branch 'upstream/master' into master-dtp

7dd9fc8

Merge remote-tracking branch 'upstream/master' into master-dtp

debf243

Merge remote-tracking branch 'upstream/master' into master-dtp

36bfb5f

Merge remote-tracking branch 'upstream/master' into master-dtp

09bb4d9

Fixes upload time bug. Upload time wasn't being populated

9be9ff9

Merge branch 'master' of /~https://github.com/google/data-transfer-project

df1de36

Merge branch 'master' of github.com:aksingh737/data-transfer-project …

7671b3e

…into uploadTimeBug

remove unused code

330465f

remove en secrets

ec8d12f

remove useless changelist

b70332d

Merge pull request #1 from aksingh737/uploadTimeBug

5dc41e7

Add creation time field to GoogleMediaItem and populate the upload time for the media models.

aksingh737 requested review from osamahan999 and jzacsh November 28, 2023 23:20

osamahan999 reviewed Nov 28, 2023

View reviewed changes

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java Outdated Show resolved Hide resolved

jzacsh reviewed Nov 28, 2023

View reviewed changes

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java Outdated Show resolved Hide resolved

osamahan999 reviewed Nov 28, 2023

View reviewed changes

...c/test/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItemTest.java Outdated Show resolved Hide resolved

jzacsh reviewed Nov 28, 2023

View reviewed changes

...c/test/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItemTest.java Outdated Show resolved Hide resolved

jzacsh reviewed Nov 28, 2023

View reviewed changes

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java Outdated Show resolved Hide resolved

...gle/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/MediaMetadata.java Show resolved Hide resolved

aksingh737 and others added 4 commits November 29, 2023 00:51

adressed the comments on the changelist

d450001

Merge pull request #2 from aksingh737/uploadTimeBug

b1feaa9

adressed the comments on the changelist

fix tests

c66c0ae

Merge pull request #3 from aksingh737/uploadTimeBug

67fe6f9

fix tests

jzacsh requested changes Nov 29, 2023

View reviewed changes

Verify creationTime is not null and can be parsed. Skip item if metad…

ab251a1

…ata is corrupted.

osamahan999 requested changes Dec 1, 2023

View reviewed changes

Removed nullException check and addressed comments.

d00ea59

osamahan999 reviewed Dec 6, 2023

View reviewed changes

...e/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java Outdated Show resolved Hide resolved

osamahan999 previously approved these changes Dec 6, 2023

View reviewed changes

osamahan999 mentioned this pull request Dec 7, 2023

Helper class for when Google code wants to log errors that may have failed an item outside of the executors #1315

Merged

aksingh737 and others added 2 commits December 8, 2023 09:50

Merge branch 'google:master' into uploadTimeBug

86ef255

Merge remote-tracking branch 'upstream/master' into uploadTimeBug

4368ad9

osamahan999 requested a review from jzacsh December 8, 2023 20:14

aksingh737 added 4 commits December 20, 2023 18:57

Merge branch 'uploadTimeBug' of github.com:aksingh737/data-transfer-p…

31ccd8e

…roject into uploadTimeBug

Merge remote-tracking branch 'origin' into uploadTimeBug

1c073bb

Merge remote-tracking branch 'upstream/master' into uploadTimeBug

31a9958

Add errorlogging for failed media items

9463c30

aksingh737 dismissed osamahan999’s stale review via 9463c30 December 20, 2023 20:46

aksingh737 added 3 commits December 20, 2023 20:52

Inlined errorDetail

bb83ca0

Merge remote-tracking branch 'upstream/master' into uploadTimeBug

45b82db

# Conflicts: # extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java

Logged errors and addressed merge issues

6660d6e

osamahan999 reviewed Dec 20, 2023

View reviewed changes

Catching exception in a single block

1ca3610

osamahan999 reviewed Dec 21, 2023

View reviewed changes

...e/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosExporter.java Outdated Show resolved Hide resolved

osamahan999 reviewed Dec 21, 2023

View reviewed changes

...e/src/main/java/org/datatransferproject/datatransfer/google/videos/GoogleVideosExporter.java Outdated Show resolved Hide resolved

osamahan999 previously approved these changes Dec 21, 2023

View reviewed changes

Added error logging to GoogleVideoExporter

f4a0855

aksingh737 dismissed osamahan999’s stale review via f4a0855 December 21, 2023 21:50

aksingh737 requested a review from osamahan999 January 2, 2024 18:17

osamahan999 reviewed Jan 2, 2024

View reviewed changes

...e/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/GoogleMediaItem.java Show resolved Hide resolved

osamahan999 approved these changes Jan 2, 2024

View reviewed changes

aksingh737 closed this Jan 2, 2024

aksingh737 reopened this Jan 2, 2024

aksingh737 requested review from jzacsh and removed request for jzacsh January 2, 2024 23:41

jzacsh approved these changes Jan 3, 2024

View reviewed changes

aksingh737 merged commit d911ff5 into dtinit:master Jan 3, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add creation time field to GoogleMediaItem and populate the upload time for the media models. #1306

Add creation time field to GoogleMediaItem and populate the upload time for the media models. #1306

aksingh737 commented Nov 28, 2023

jzacsh left a comment

jzacsh commented Nov 29, 2023

osamahan999 left a comment

Add creation time field to GoogleMediaItem and populate the upload time for the media models. #1306

Add creation time field to GoogleMediaItem and populate the upload time for the media models. #1306

Conversation

aksingh737 commented Nov 28, 2023

jzacsh left a comment

Choose a reason for hiding this comment

jzacsh commented Nov 29, 2023

osamahan999 left a comment

Choose a reason for hiding this comment