Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xWebSite: Resolve casing in name #535

Closed
johlju opened this issue Oct 15, 2019 · 0 comments · Fixed by #538
Closed

xWebSite: Resolve casing in name #535

johlju opened this issue Oct 15, 2019 · 0 comments · Fixed by #538
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/

Comments

@johlju
Copy link
Member

johlju commented Oct 15, 2019

There are files and folders that are named Website instead of WebSite(upper-case 'S'). Also code referencing Website should be changed to WebSite.

Throughout the repository.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ help wanted The issue is up for grabs for anyone in the community. labels Oct 15, 2019
@johlju johlju changed the title xWebSite: Resolve casing in name throughout the repo xWebSite: Resolve casing in name Oct 15, 2019
RandomNoun7 added a commit to RandomNoun7/xWebAdministration that referenced this issue Oct 16, 2019
@RandomNoun7
xWebSite: Resolve Resource Name Case
e5cb693 
Prior to this change the case used in the resource name `xWebsite` was
inconsistant and should have been `xWebSite` in all instances.

- Fixes dsccommunity#535

- [x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
      Entry should say what was changed and how that affects users (if applicable), and
      reference the issue being resolved (if applicable).
- [x] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
      and comment-based help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [x] Examples appropriately added/updated.
- [x] Unit tests added/updated. See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] New/changed code adheres to [DSC Resource Style Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](/~https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
RandomNoun7 added a commit to RandomNoun7/xWebAdministration that referenced this issue Oct 16, 2019
@RandomNoun7
xWebSite: Resolve Resource Name Case
ef4bae9 
Prior to this change the case used in the resource name `xWebsite` was
inconsistant and should have been `xWebSite` in all instances.

- Fixes dsccommunity#535

- [x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
      Entry should say what was changed and how that affects users (if applicable), and
      reference the issue being resolved (if applicable).
- [x] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
      and comment-based help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [x] Examples appropriately added/updated.
- [x] Unit tests added/updated. See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] New/changed code adheres to [DSC Resource Style Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](/~https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
@RandomNoun7 RandomNoun7 mentioned this issue Oct 16, 2019
Merged
9 tasks
RandomNoun7 added a commit to RandomNoun7/xWebAdministration that referenced this issue Oct 20, 2019
@RandomNoun7
xWebSite: Resolve Resource Name Case
1f1e2b0 
Prior to this change the case used in the resource name `xWebsite` was
inconsistant and should have been `xWebSite` in all instances.

- Fixes dsccommunity#535

- [x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
      Entry should say what was changed and how that affects users (if applicable), and
      reference the issue being resolved (if applicable).
- [x] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
      and comment-based help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [x] Examples appropriately added/updated.
- [x] Unit tests added/updated. See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] New/changed code adheres to [DSC Resource Style Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](/~https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
RandomNoun7 added a commit to RandomNoun7/xWebAdministration that referenced this issue Oct 20, 2019
@RandomNoun7
xWebSite: Resolve Resource Name Case
238981e 
Prior to this change the case used in the resource name `xWebsite` was
inconsistant and should have been `xWebSite` in all instances.

- Fixes dsccommunity#535

- [x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
      Entry should say what was changed and how that affects users (if applicable), and
      reference the issue being resolved (if applicable).
- [x] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
      and comment-based help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [x] Examples appropriately added/updated.
- [x] Unit tests added/updated. See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] New/changed code adheres to [DSC Resource Style Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](/~https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
RandomNoun7 added a commit to RandomNoun7/xWebAdministration that referenced this issue Oct 20, 2019
@RandomNoun7
xWebSite: Resolve Resource Name Case
82853a8 
Prior to this change the case used in the resource name `xWebsite` was
inconsistant and should have been `xWebSite` in all instances.

- Fixes dsccommunity#535

- [x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
      Entry should say what was changed and how that affects users (if applicable), and
      reference the issue being resolved (if applicable).
- [x] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
      and comment-based help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [x] Examples appropriately added/updated.
- [x] Unit tests added/updated. See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] New/changed code adheres to [DSC Resource Style Guidelines](/~https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](/~https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
johlju pushed a commit that referenced this issue Oct 23, 2019
@RandomNoun7 @johlju
xWebSite/xWebSiteDefaults : Resolve Resource Name Case (#538)
7c15d40 
- Changes to xWebSite
  - Fix case of resource name from `xWebsite` to `xWebSite` (issue #535).
- Changes to xWebSiteDefaults
  - Fix case of resource name from `xWebsiteDefaults` to `xWebSiteDefaults` (issue #535).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Oct 23, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this issue Feb 14, 2020
@RandomNoun7
xWebSite/xWebSiteDefaults : Resolve Resource Name Case (dsccommunity#538
f237fcb 
)

- Changes to xWebSite
  - Fix case of resource name from `xWebsite` to `xWebSite` (issue dsccommunity#535).
- Changes to xWebSiteDefaults
  - Fix case of resource name from `xWebsiteDefaults` to `xWebSiteDefaults` (issue dsccommunity#535).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xWebSite: Resolve Resource Name Case RandomNoun7/xWebAdministration
1 participant
@johlju