Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable manager user's features #598

Merged
merged 5 commits into from
Sep 3, 2021
Merged

feat: enable manager user's features #598

merged 5 commits into from
Sep 3, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Sep 3, 2021

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Enable jwt.
  • Enable rbac.
  • Add user's display interface.
  • Fix the resource not found destroy report 404.
  • Fix frontend router conflict.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Sep 3, 2021
@gaius-qi gaius-qi self-assigned this Sep 3, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner September 3, 2021 02:42
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #598 (1fc368b) into main (d2e70b2) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
+ Coverage   38.56%   38.75%   +0.18%     
==========================================
  Files          87       87              
  Lines        6856     6856              
==========================================
+ Hits         2644     2657      +13     
+ Misses       3835     3824      -11     
+ Partials      377      375       -2     
Flag Coverage Δ
compatibility-e2etests ?
e2etests ?
unittests 38.75% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 34.07% <0.00%> (+0.60%) ⬆️
client/daemon/peer/peertask_stream_callback.go 64.55% <0.00%> (+2.53%) ⬆️
client/daemon/peer/peertask_stream.go 56.94% <0.00%> (+2.71%) ⬆️

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi changed the title feat: enable jwt feat: enable jwt and enable rbac Sep 3, 2021
@gaius-qi gaius-qi changed the title feat: enable jwt and enable rbac feat: enable manager user's features Sep 3, 2021
@gaius-qi gaius-qi merged commit 1186aef into main Sep 3, 2021
@gaius-qi gaius-qi deleted the feature/enable-jwt branch September 3, 2021 10:28
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: enable manager user's features

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants