Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let cdn support sha256 #517

Merged
merged 9 commits into from
Aug 6, 2021
Merged

let cdn support sha256 #517

merged 9 commits into from
Aug 6, 2021

Conversation

zzy987
Copy link
Contributor

@zzy987 zzy987 commented Aug 4, 2021 •
edited by 244372610
Loading

let cdn support sha256
fix #517

zzy987 added 3 commits August 2, 2021 17:30
@zzy987
feat: support sha256 in cdn
455eeae 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
@zzy987
fix: set default digest type md5
c8352e0 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
@zzy987
chore: merge main and feature/sha256
366da05 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
@zzy987 zzy987 requested a review from a team as a code owner August 4, 2021 02:43
@zzy987 zzy987 linked an issue Aug 4, 2021 that may be closed by this pull request
CDN supports sha256 as digest #512
Closed
zzy987 added 2 commits August 4, 2021 11:04
@zzy987
chore: modify the field names in unit test
2d6cb05 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
@zzy987
chore: use digest in sync tasks
68fcb55 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #517 (1692ecc) into main (86620ca) will increase coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   39.34%   39.42%   +0.08%     
==========================================
  Files          85       86       +1     
  Lines        6438     6536      +98     
==========================================
+ Hits         2533     2577      +44     
- Misses       3539     3589      +50     
- Partials      366      370       +4
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.42% <50.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdnsystem/daemon/task/manager_util.go 0.00% <0.00%> (ø)
cdnsystem/server/service/cdn_seed_server.go 0.00% <0.00%> (ø)
pkg/util/digestutils/digest.go 38.09% <10.00%> (-8.97%) ⬇️
cdnsystem/daemon/cdn/cache_detector.go 53.91% <50.00%> (ø)
client/dfget/dfget.go 15.32% <50.00%> (ø)
cdnsystem/daemon/cdn/manager.go 59.61% <90.90%> (+2.03%) ⬆️
cdnsystem/daemon/cdn/cache_data_mgr.go 76.40% <100.00%> (ø)
pkg/source/httpprotocol/http_source_client.go 66.26% <0.00%> (-3.60%) ⬇️
client/daemon/peer/peertask_stream.go 55.24% <0.00%> (-2.37%) ⬇️
manager/config/config.go 0.00% <0.00%> (ø)
... and 10 more

gaius-qi
gaius-qi requested changes Aug 5, 2021
View reviewed changes
cdnsystem/daemon/cdn/manager_test.go Outdated Show resolved Hide resolved
cdnsystem/daemon/task/manager_test.go Show resolved Hide resolved
pkg/ratelimiter/limitreader/limit_reader.go Outdated Show resolved Hide resolved
pkg/util/digestutils/digest.go Show resolved Hide resolved
cdnsystem/daemon/cdn/manager.go Outdated Show resolved Hide resolved
zzy987 added 3 commits August 5, 2021 17:41
@zzy987
chore: use digest.Algorithm for hash algorithms
7b6dc6f 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
@zzy987
test: add test for sha256
1c7ab47 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
@zzy987
chore: move digest algorithm into digestutil package
dfd95e2 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
gaius-qi
gaius-qi previously approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzy987
chore: cdn use md5 by default, rename md5 to digest while detect cache
1692ecc 
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
gaius-qi
gaius-qi approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzy987 zzy987 merged commit 9a0d057 into dragonflyoss:main Aug 6, 2021
@zzy987 zzy987 deleted the feature/sha256 branch August 6, 2021 08:51
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@zzy987 @gaius-qi
let cdn support sha256 (#517)
39ce5d9 
cdn support sha256 digest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@244372610 244372610 244372610 approved these changes

@gaius-qi gaius-qi gaius-qi approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985

@ansinlee ansinlee Awaiting requested review from ansinlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDN supports sha256 as digest
4 participants
@zzy987 @codecov-commenter @gaius-qi @244372610