Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize scheduler dynconfig #480

Merged
merged 9 commits into from
Jul 20, 2021
Merged

feat: optimize scheduler dynconfig #480

merged 9 commits into from
Jul 20, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Scheduler read dynconfig from default configuration.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Jul 20, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner July 20, 2021 10:08
@gaius-qi gaius-qi self-assigned this Jul 20, 2021
gaius-qi added 6 commits July 20, 2021 18:09
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #480 (79eaadc) into main (bb62211) will increase coverage by 0.12%.
The diff coverage is 68.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   36.41%   36.53%   +0.12%     
==========================================
  Files          89       90       +1     
  Lines        6959     7009      +50     
==========================================
+ Hits         2534     2561      +27     
- Misses       4058     4084      +26     
+ Partials      367      364       -3     
Flag Coverage Δ
e2etests ?
unittests 36.53% <68.57%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <0.00%> (ø)
scheduler/manager/cdn_manager.go 4.37% <28.57%> (ø)
internal/dynconfig/dynconfig_local.go 71.42% <50.00%> (ø)
internal/dynconfig/dynconfig.go 61.40% <100.00%> (+8.37%) ⬆️
internal/dynconfig/dynconfig_manager.go 71.42% <100.00%> (ø)
scheduler/config/dynconfig.go 55.12% <100.00%> (+7.36%) ⬆️
client/config/peerhost.go 35.48% <0.00%> (ø)
client/daemon/proxy/reverse_proxy.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_base.go 32.94% <0.00%> (+0.72%) ⬆️
client/daemon/peer/piece_manager.go 67.88% <0.00%> (+0.81%) ⬆️
... and 1 more

gaius-qi added 2 commits July 20, 2021 20:15
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi changed the title feat: scheduler feat: optimize scheduler dynconfig Jul 20, 2021
@gaius-qi gaius-qi merged commit 8efafd8 into main Jul 20, 2021
@gaius-qi gaius-qi deleted the feature/dynamic-config branch July 20, 2021 12:56
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: optimize scheduler dynconfig

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants