Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address typo #468

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Fix address typo #468

merged 2 commits into from
Jul 20, 2021

Conversation

Bowser1704
Copy link
Contributor

@Bowser1704 Bowser1704 commented Jul 16, 2021

Description

fix the address (addr) typo and improvement a comment.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Bowser1704 <bowser1704@gmail.com>
Signed-off-by: Bowser1704 <bowser1704@gmail.com>
@Bowser1704 Bowser1704 requested a review from a team as a code owner July 16, 2021 15:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #468 (57f14c1) into main (7659def) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   36.54%   36.51%   -0.03%     
==========================================
  Files          89       89              
  Lines        6959     6959              
==========================================
- Hits         2543     2541       -2     
- Misses       4048     4051       +3     
+ Partials      368      367       -1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 36.51% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/service/manager.go 33.00% <ø> (ø)
client/daemon/peer/peertask_stream.go 56.25% <0.00%> (-0.74%) ⬇️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 11acf4f into dragonflyoss:main Jul 20, 2021
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* fix: typo change adder to addr

Signed-off-by: Bowser1704 <bowser1704@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants