Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disk bandwidth information for host #3652

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat: add disk bandwidth information for host #3652

merged 1 commit into from
Nov 18, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Nov 18, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 18, 2024
@gaius-qi gaius-qi self-assigned this Nov 18, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner November 18, 2024 10:21
@gaius-qi gaius-qi force-pushed the feature/disk branch 3 times, most recently from fbe9df1 to f765512 Compare November 18, 2024 10:31
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.

Project coverage is 35.42%. Comparing base (11d6564) to head (74a1452).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/resource/persistentcache/host_manager.go 0.00% 14 Missing ⚠️
scheduler/scheduler.go 0.00% 2 Missing ⚠️
scheduler/service/service_v2.go 85.71% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3652      +/-   ##
==========================================
- Coverage   35.69%   35.42%   -0.28%     
==========================================
  Files         337      335       -2     
  Lines       37935    37531     -404     
==========================================
- Hits        13541    13295     -246     
+ Misses      23555    23407     -148     
+ Partials      839      829      -10     
Flag Coverage Δ
unittests 35.42% <51.35%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/announcer/announcer.go 91.42% <100.00%> (-0.24%) ⬇️
scheduler/resource/persistentcache/host.go 100.00% <ø> (ø)
scheduler/resource/standard/host.go 88.23% <ø> (ø)
scheduler/rpcserver/rpcserver.go 100.00% <100.00%> (ø)
scheduler/rpcserver/scheduler_server_v1.go 2.66% <100.00%> (ø)
scheduler/rpcserver/scheduler_server_v2.go 1.26% <100.00%> (ø)
scheduler/scheduling/scheduling.go 84.36% <100.00%> (+0.06%) ⬆️
scheduler/service/service_v1.go 85.02% <ø> (+5.91%) ⬆️
scheduler/scheduler.go 0.00% <0.00%> (ø)
scheduler/service/service_v2.go 68.24% <85.71%> (+0.13%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit b2c8e76 into main Nov 18, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/disk branch November 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants