Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support searching task by url for GetTask and DeleteTask #3607

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 24, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 24, 2024
@gaius-qi gaius-qi self-assigned this Oct 24, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 24, 2024 13:33
@gaius-qi gaius-qi force-pushed the feature/task branch 2 times, most recently from ae78146 to 2e7bb47 Compare October 24, 2024 15:19
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 35.80%. Comparing base (bad6972) to head (502baef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/handlers/job.go 0.00% 6 Missing and 2 partials ⚠️
manager/job/task.go 60.00% 4 Missing and 2 partials ⚠️
scheduler/job/job.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
+ Coverage   35.77%   35.80%   +0.02%     
==========================================
  Files         339      339              
  Lines       37308    37326      +18     
==========================================
+ Hits        13348    13364      +16     
+ Misses      23125    23123       -2     
- Partials      835      839       +4     
Flag Coverage Δ
unittests 35.80% <46.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/idgen/task_id.go 79.06% <100.00%> (ø)
scheduler/job/job.go 0.00% <0.00%> (ø)
manager/job/task.go 69.69% <60.00%> (-2.40%) ⬇️
manager/handlers/job.go 55.55% <0.00%> (-4.45%) ⬇️

... and 5 files with indirect coverage changes

@gaius-qi gaius-qi changed the title feat: support searching task by url for GetTask and DeleteTask [WIP]feat: support searching task by url for GetTask and DeleteTask Oct 24, 2024
@gaius-qi gaius-qi force-pushed the feature/task branch 5 times, most recently from 37da616 to e0fd5a1 Compare October 28, 2024 09:13
@gaius-qi gaius-qi changed the title [WIP]feat: support searching task by url for GetTask and DeleteTask feat: support searching task by url for GetTask and DeleteTask Oct 28, 2024
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi requested a review from a team as a code owner October 28, 2024 09:46
@gaius-qi gaius-qi requested a review from jim3ma October 28, 2024 09:46
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 5a51a61 into main Oct 28, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/task branch October 28, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants