Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add persistent cache task for scheduler #3545

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Sep 29, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 29, 2024
@gaius-qi gaius-qi self-assigned this Sep 29, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 29, 2024 13:02
@gaius-qi gaius-qi changed the title Feature/presistent feat: add persistent cache task for scheduler Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 51.82%. Comparing base (7a83e5a) to head (fa901ae).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/redis/redis.go 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3545      +/-   ##
==========================================
- Coverage   51.85%   51.82%   -0.04%     
==========================================
  Files         190      190              
  Lines       20488    20481       -7     
==========================================
- Hits        10625    10614      -11     
- Misses       9054     9061       +7     
+ Partials      809      806       -3     
Flag Coverage Δ
unittests 51.82% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/standard/resource.go 64.28% <ø> (+4.28%) ⬆️
scheduler/resource/standard/task.go 78.09% <ø> (+0.66%) ⬆️
pkg/redis/redis.go 60.60% <0.00%> (-13.47%) ⬇️

... and 1 file with indirect coverage changes

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit 53f5e9c into main Sep 29, 2024
29 checks passed
@gaius-qi gaius-qi deleted the feature/presistent branch September 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants