Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename scheduler/resource to scheduler/resource/standard #3542

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Sep 29, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 29, 2024
@gaius-qi gaius-qi self-assigned this Sep 29, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 29, 2024 03:51
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.88%. Comparing base (9cd6f41) to head (ac0a463).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3542      +/-   ##
==========================================
- Coverage   51.90%   51.88%   -0.02%     
==========================================
  Files         190      190              
  Lines       20488    20488              
==========================================
- Hits        10634    10631       -3     
- Misses       9048     9050       +2     
- Partials      806      807       +1     
Flag Coverage Δ
unittests 51.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/daemon/rpcserver/rpcserver.go 49.24% <ø> (ø)
manager/job/sync_peers.go 0.00% <ø> (ø)
scheduler/networktopology/network_topology.go 100.00% <ø> (ø)
scheduler/networktopology/probes.go 100.00% <ø> (ø)
scheduler/resource/standard/host.go 90.32% <ø> (ø)
scheduler/resource/standard/host_manager.go 74.28% <ø> (ø)
scheduler/resource/standard/host_manager_mock.go 31.81% <ø> (ø)
scheduler/resource/standard/peer.go 71.98% <ø> (ø)
scheduler/resource/standard/peer_manager.go 74.50% <ø> (ø)
scheduler/resource/standard/peer_manager_mock.go 8.00% <ø> (ø)
... and 19 more

... and 1 file with indirect coverage changes

Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 688b9d7 into main Sep 29, 2024
22 of 29 checks passed
@gaius-qi gaius-qi deleted the feature/standard branch September 29, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants