Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support preheat with self-signed certs #3541

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat: support preheat with self-signed certs #3541

merged 1 commit into from
Sep 26, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Sep 26, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 26, 2024
@gaius-qi gaius-qi self-assigned this Sep 26, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 26, 2024 14:32
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (1afe79e) to head (8c172b4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/job/preheat.go 30.00% 7 Missing ⚠️
manager/job/job.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   51.88%   51.85%   -0.03%     
==========================================
  Files         190      190              
  Lines       20483    20488       +5     
==========================================
- Hits        10628    10625       -3     
- Misses       9047     9053       +6     
- Partials      808      810       +2     
Flag Coverage Δ
unittests 51.85% <30.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/config/config.go 96.33% <100.00%> (-0.04%) ⬇️
manager/job/job.go 16.00% <0.00%> (ø)
manager/job/preheat.go 50.91% <30.00%> (-0.75%) ⬇️

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi merged commit ea850f7 into main Sep 26, 2024
28 of 29 checks passed
@gaius-qi gaius-qi deleted the feature/cert branch September 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants