Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix network topology e2e test #3171

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

MinH-09
Copy link
Contributor

@MinH-09 MinH-09 commented Apr 8, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@MinH-09 MinH-09 requested a review from a team as a code owner April 8, 2024 10:42
@MinH-09 MinH-09 changed the title fix: fix network topology e2e tes fix: fix network topology e2e test Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.81%. Comparing base (fc53dcf) to head (d129666).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3171   +/-   ##
=======================================
  Coverage   51.81%   51.81%           
=======================================
  Files         163      163           
  Lines       18693    18693           
=======================================
+ Hits         9685     9686    +1     
+ Misses       8333     8332    -1     
  Partials      675      675           
Flag Coverage Δ
unittests 51.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@MinH-09 MinH-09 force-pushed the main branch 7 times, most recently from 9cf6a1b to 3100ea0 Compare April 9, 2024 00:48
Signed-off-by: huangmin <2107139596@qq.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c168e86 into dragonflyoss:main Apr 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants