Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove otel in client #3169

Merged
merged 1 commit into from
Apr 8, 2024
Merged

feat: remove otel in client #3169

merged 1 commit into from
Apr 8, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Apr 8, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Apr 8, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Apr 8, 2024
@gaius-qi gaius-qi self-assigned this Apr 8, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner April 8, 2024 08:54
jim3ma
jim3ma previously approved these changes Apr 8, 2024
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.86%. Comparing base (67bb7a6) to head (c3c419d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
- Coverage   51.87%   51.86%   -0.02%     
==========================================
  Files         163      163              
  Lines       18672    18675       +3     
==========================================
- Hits         9687     9686       -1     
- Misses       8308     8312       +4     
  Partials      677      677              
Flag Coverage Δ
unittests 51.86% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/resource/resource.go 64.28% <100.00%> (ø)

... and 2 files with indirect coverage changes

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit cce656a into main Apr 8, 2024
15 of 23 checks passed
@gaius-qi gaius-qi deleted the feature/otel branch April 8, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants