Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tunnel https #3153

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: tunnel https #3153

merged 2 commits into from
Apr 8, 2024

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Mar 28, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner March 28, 2024 09:50
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 51.89%. Comparing base (6099a91) to head (fe6daaa).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3153      +/-   ##
==========================================
- Coverage   51.90%   51.89%   -0.02%     
==========================================
  Files         163      163              
  Lines       18621    18657      +36     
==========================================
+ Hits         9666     9682      +16     
- Misses       8292     8300       +8     
- Partials      663      675      +12     
Flag Coverage Δ
Object-compatibility-e2etests ?
unittests 51.89% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/daemon/proxy/proxy.go 14.28% <0.00%> (-0.15%) ⬇️

... and 6 files with indirect coverage changes

Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit f960bc0 into main Apr 8, 2024
23 checks passed
@gaius-qi gaius-qi deleted the fix/tunnel-https branch April 8, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants