Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a regex bug with escaping inside of character classes #4575

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: a regex bug with escaping inside of character classes #4575

merged 1 commit into from
Feb 7, 2025

Conversation

romange
Copy link
Collaborator

@romange romange commented Feb 7, 2025

Also delete the broken docker weekly flow.

@romange
fix: a regex bug with escaping inside of character classes
134145e 
Also delete the broken docker weekly flow.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange requested a review from kostasrim February 7, 2025 09:49
@romange romange enabled auto-merge (squash) February 7, 2025 09:57
@kostasrim
Copy link
Contributor

@romange

2025-02-07T10:00:51.3892189Z 52: [  FAILED  ] 1 test, listed below:
2025-02-07T10:00:51.3892666Z 52: [  FAILED  ] DflyEngineTest.Bug207
2025-02-07T10:00:51.3893096Z 52: 
2025-02-07T10:00:51.3893382Z 52:  1 FAILED TEST
2025-02-07T10:00:51.3902343Z 31/55 Test #52: dragonfly_test ...................***Failed    4.34 sec

It failed for me in another PR #4570

I rerun your workflow, will accept soon

@romange romange merged commit acde373 into main Feb 7, 2025
10 checks passed
@romange romange deleted the Pr3 branch February 7, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostasrim kostasrim kostasrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romange @kostasrim