Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the uri format #127

Closed
rlouf opened this issue Dec 17, 2024 · 4 comments · Fixed by #129
Closed

Support the uri format #127

rlouf opened this issue Dec 17, 2024 · 4 comments · Fixed by #129
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rlouf
Copy link
Member

rlouf commented Dec 17, 2024

The Json Schema specification defines the uri pre-built format, which is not yet implemented in outlines-core.
@rlouf rlouf added enhancement New feature or request good first issue Good for newcomers labels Dec 17, 2024
@sky-2002
Copy link
Contributor

@rlouf is this supposed to be added in the parsing.rs to_regex?

@rlouf
Copy link
Member Author

rlouf commented Dec 18, 2024

It should be implemented in parse_string_type as the format keyword applies to string types.

@sky-2002 sky-2002 mentioned this issue Dec 19, 2024
Merged
@sky-2002
Copy link
Contributor

sky-2002 commented Dec 19, 2024 •
edited
Loading

yeah 👍🏻 , to_regex --> parse_type --> parse_string_type
Edit: Actually in FormatType

torymur pushed a commit that referenced this issue Dec 19, 2024
@sky-2002
Support URI format (#129)
60e58fb 
Adds URI parsing code and tests

Refer #127
@torymur
Copy link
Contributor

torymur commented Dec 19, 2024

Was closed by #129

@torymur torymur closed this as completed Dec 19, 2024
sky-2002 added a commit to sky-2002/outlines-core that referenced this issue Dec 19, 2024
@sky-2002
Support URI format (dottxt-ai#129)
421ed8c 
Adds URI parsing code and tests

Refer dottxt-ai#127
sky-2002 added a commit to sky-2002/outlines-core that referenced this issue Dec 19, 2024
@sky-2002
Support URI format (dottxt-ai#129)
b44fc95 
Adds URI parsing code and tests

Refer dottxt-ai#127
sky-2002 added a commit to sky-2002/outlines-core that referenced this issue Dec 19, 2024
@sky-2002
Support URI format (dottxt-ai#129)
b7f63ba 
Adds URI parsing code and tests

Refer dottxt-ai#127
sky-2002 added a commit to sky-2002/outlines-core that referenced this issue Dec 19, 2024
@sky-2002
Support URI format (dottxt-ai#129)
a40ea01 
Adds URI parsing code and tests

Refer dottxt-ai#127
torymur pushed a commit to sky-2002/outlines-core that referenced this issue Dec 20, 2024
@sky-2002 @torymur
Support URI format (dottxt-ai#129)
fbab8a8 
Adds URI parsing code and tests

Refer dottxt-ai#127
torymur pushed a commit to sky-2002/outlines-core that referenced this issue Dec 20, 2024
@sky-2002 @torymur
Support URI format (dottxt-ai#129)
792ddb1 
Adds URI parsing code and tests

Refer dottxt-ai#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support URI format sky-2002/outlines-core
3 participants
@torymur @rlouf @sky-2002