Revert private assets in deps.json change (#45259) #46182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
requested review from
a team,
tmat,
AntonLapounov and
vijayrkn
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
1 similar comment
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
dsplaisted
approved these changes
Jan 23, 2025
|
/backport to main |
|
Started backporting to main: /~https://github.com/dotnet/sdk/actions/runs/12987844242 |
nguerrera
added a commit
to nguerrera/cask
that referenced
this pull request
Jan 31, 2025
For a period, there was breaking SDK change with `PrivateAssets="all"` stripping things from the build `deps.json`. It's been [reverted](dotnet/sdk#46182) but that revert hasn't made it to preview builds of VS yet. While this breaking change is around, having a `PrivateAssets="all"` reference to `Microsoft.NET.Test.Sdk` causes: ``` Testhost process for source(s) 'D:\Src\cask\bld\bin\Cask.Tests\debug_net8.0\Cask.Tests.dll' exited with error: Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.TestPlatform.CoreUtilities, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.` ``` There's no real reason for our `Microsoft.NET.Test.Sdk` reference to have `PrivateAssets="all"` and removing it works around the issue, so this change removes it.
nguerrera
added a commit
to microsoft/cask
that referenced
this pull request
Jan 31, 2025
For a period, there was breaking SDK change with `PrivateAssets="all"` stripping things from the build `deps.json`. It's been [reverted](dotnet/sdk#46182) but that revert hasn't made it to preview builds of VS yet. While this breaking change is around, having a `PrivateAssets="all"` reference to `Microsoft.NET.Test.Sdk` causes: ``` Testhost process for source(s) 'D:\Src\cask\bld\bin\Cask.Tests\debug_net8.0\Cask.Tests.dll' exited with error: Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.TestPlatform.CoreUtilities, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.` ``` There's no real reason for our `Microsoft.NET.Test.Sdk` reference to have `PrivateAssets="all"` and removing it works around the issue, so this change removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/roslyn#76797