-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XAML files are not supported #810
Comments
FYI. @srivatsn, @jinujoseph, @nguerrera |
This completely blocks the porting of WPF based applications to CPS (I imagine it would also block UWP and anything else that uses XAML). |
Yes WPF and any other desktop projects are not supported yet. Currently only .NET Core projects are supported. |
This issue was moved to dotnet/project-system#1467 |
It seems like this issue is more about whether you can build a WPF project successfully rather than whether the IDE supports it. |
Yes. I can manually override things (as I did in the sample) so that the UI designer in VS and everything else works. I would think that, of the four issues I listed, two of them are applicable to the SDK repository (as they impact command line builds) and two to the Project System repository (they really only impact the IDE). SDK
Project System:
|
here are some workarounds for now issues 1 and 2: issue 3: issue 4: |
more complete version of the workarounds i use these days - import this at the end of a csproj <Project>
<!-- /~https://github.com/dotnet/sdk/issues/810 - the temporary project has the wrong file extension -->
<PropertyGroup>
<LanguageTargets>$(MSBuildToolsPath)\Microsoft.CSharp.targets</LanguageTargets>
<StartWorkingDirectory Condition="'$(OutputType)' == 'WinExe'">bin/$(Configuration)/$(TargetFramework)</StartWorkingDirectory>
</PropertyGroup>
<!-- Page items aren't included by the SDK -->
<ItemGroup>
<Page Include="**\*.xaml" Exclude="@(ApplicationDefinition)" SubType="Designer" Generator="MSBuild:Compile" />
<Compile Update="**\*.xaml.cs" SubType="Code" DependentUpon="%(Filename)" />
<UpToDateCheckInput Include="**\*.xaml" />
</ItemGroup>
<!-- /~https://github.com/dotnet/project-system/issues/2488 - .g.cs files don't get built -->
<Target Name="WorkaroundForXAMLIntellisenseBuildIssue" AfterTargets="_CheckCompileDesignTimePrerequisite">
<PropertyGroup>
<BuildingProject>false</BuildingProject>
</PropertyGroup>
</Target>
</Project> |
Merge Master to release/3.0.1xx
Due to lack of recent activity, this issue has been labeled as 'stale'. It will be closed if no further activity occurs within 30 more days. Any new comment will remove the label. |
This issue will now be closed since it has been labeled 'stale' without activity for 30 days. |
Attached is a simple repro solution.
WpfCps.zip
Issue 1: XAML files are treated as
None
, when they should be treated asPage
withGenerator=MSBuild:Compile
andSubType=Designer
metadata.Issue 2:
Page
items are not visible in the Solution ExplorerIssue 3: xaml.cs files are not properly nested under the xaml file
Issue 4: Compilation fails with:
1>C:\windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.WinFx.targets(419,45): error MSB4057: The target "CoreCompile" does not exist in the project.
The text was updated successfully, but these errors were encountered: