[release/6.0-staging] Disable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds #96055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…g_Succeeds The 3rd party service has expired certificate
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #79407 to release/6.0-staging /cc @rzikm Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
This was referenced Dec 15, 2023
Merged
rzikm
changed the title
stephentoub
approved these changes
Jan 2, 2024
|
Test-only change => tell mode, adding Servicing-approved |
|
CI Faliures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79407 to release/6.0-staging
7.0 PR is #96053
Fixes #91705
/cc @rzikm, @karelz
Customer Impact
Test only change to clean up CI. The test uses external server (badssl.com) which has now expired certificate (see also chromium/badssl.com#515). The test fails because the certificate validation errors differ from the tests expectations.
Testing
Will run CI to check affected test.
Risk
Low, test-only change.