[wasm][debugger] Support multidimensional indexing of object scheme #92630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes #76062. Out of scope:
|
thaystg
reviewed
Sep 26, 2023
thaystg
approved these changes
Sep 26, 2023
|
/backport to release/8.0 |
|
Started backporting to release/8.0: /~https://github.com/dotnet/runtime/actions/runs/6335748733 |
|
@ilonatommy backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Multidim working, indexing by constant got broken.
Applying: Fix failing test (indexing with literals).
Applying: Cleenup + new tests.
Applying: Comma removal
Applying: More tests.
Applying: Fix simple case of nested indexing.
Applying: Fixed one test, found another one failing.
Applying: Fix complex multiple nestings.
Applying: Remove ToDo - fixed by this PR.
error: sha1 information is lacking or useless (src/mono/wasm/debugger/tests/debugger-test/debugger-evaluate-test.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0009 Remove ToDo - fixed by this PR.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@ilonatommy an error occurred while backporting to release/8.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
ilonatommy
added a commit
to ilonatommy/runtime
that referenced
this pull request
Sep 28, 2023
carlossanlop
pushed a commit
that referenced
this pull request
Oct 3, 2023
dotnet-bot
pushed a commit
to dotnet/dotnet
that referenced
this pull request
Oct 3, 2023
Diff: /~https://github.com/dotnet/runtime/compare/b20f704cc00f390e5560a137deb8f0e64e863e1d..ef6283ac0a14c78d9e9fef4841545099bd7ad12b From: dotnet/runtime@b20f704 To: dotnet/runtime@ef6283a Commits: - Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230928.3 (#92816) dotnet/runtime@f1e4e90 - Changes from dotnet/runtime#92630 (#92753) dotnet/runtime@8632a75 - [release/8.0] [browser] Remove duplicated marshaling of return value for JSExport (#92886) dotnet/runtime@172d79a - fix dotnet/runtime#92713 (#92890) dotnet/runtime@8e365ee - [release/8.0] Update dependencies from dotnet/roslyn (#92503) dotnet/runtime@ef6283a [[ commit created by automation ]]
mthalman
pushed a commit
to mthalman/dotnet
that referenced
this pull request
Oct 25, 2023
Diff: /~https://github.com/dotnet/runtime/compare/b20f704cc00f390e5560a137deb8f0e64e863e1d..ef6283ac0a14c78d9e9fef4841545099bd7ad12b From: dotnet/runtime@b20f704 To: dotnet/runtime@ef6283a Commits: - Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230928.3 (#92816) dotnet/runtime@f1e4e90 - Changes from dotnet/runtime#92630 (#92753) dotnet/runtime@8632a75 - [release/8.0] [browser] Remove duplicated marshaling of return value for JSExport (#92886) dotnet/runtime@172d79a - fix dotnet/runtime#92713 (#92890) dotnet/runtime@8e365ee - [release/8.0] Update dependencies from dotnet/roslyn (#92503) dotnet/runtime@ef6283a [[ commit created by automation ]]
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76062.
Out of scope:
valuetypescheme [wasm][debugger] Support indexing of valuetype scheme #92637