[release/8.0-rc2] Address feedback and fix some TensorPrimitives issues #92437
Conversation
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Added a few APIs based on initial feedback: Abs (vectorized), Log2, and element-wise Max/Min{Magnitude}
- Renamed L2Normalize to Norm
- Fixed semantics of Min/MaxMagnitude to return original value rather than the absolute value
- Renamed a few helper types for consistency
- Added tests
dotnet-issue-labeler
bot
added
needs-area-label
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ericstj
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors Issue DetailsBackport of #92395 to release/8.0-rc2 /cc @michaelgsharp @stephentoub Customer ImpactFinal changes needed to get the package ready for preview by Semantic Kernel and ML.NET. TestingAutomated testing in place. RiskVery low. These are changes to a new API in a new library we haven't shipped before. No one has any dependencies on them yet. IMPORTANT: If this backport is for a servicing release, please verify that:
|
|
Approved by Tactics via email. |
carlossanlop
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Backport of #92395 to release/8.0-rc2
/cc @michaelgsharp @stephentoub
Customer Impact
Final changes needed to get the package ready for preview by Semantic Kernel and ML.NET.
Testing
Automated testing in place.
Risk
Very low. These are changes to a new API in a new library we haven't shipped before. No one has any dependencies on them yet.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.