[release/8.0-rc2] Fix options Validation with objects have indexers #92311
Conversation
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsBackport of #92309 to release/8.0-rc2 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@artl93 @ericstj @jeffhandley I am submitting a request to port this fix to RC2. This issue represents a regression that occurred in RC1, and it would be beneficial to include the resolution in RC2. |
|
@tarekgh backports to RC2 now need to go through Tactics approval, so please send them an email. Also please get a code review sign-off. BTW there was a generalized failure in the RC2 branch for which we just merged a fix, so I updated this branch to ensure we got a clean CI result. |
|
@ericstj @stephentoub this is a backport of the PR you reviewed #92309. Could you please approve it? |
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #92309 to release/8.0-rc2
/cc @tarekgh
Customer Impact
Users who perform options validations using objects containing indexers may encounter exceptions. This issue represents a regression from earlier releases and is a direct result of the changes made to support the new validation attributes, namely
ValidateObjectMembersAttributeandValidateEnumeratedItemsAttribute.Testing
Passed the regression tests and added more tests to cover the failing cases.
Risk
Low, this change is highly specific and pertains solely to cases where an object contains an indexer, with no impact on any other aspects of the logic.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.