[release/8.0] Fix support of FromKeyedServicesAttribute in ActivatorUtilities.CreateFactory #92144
Conversation
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsBackport of #92082 to release/8.0 /cc @benjaminpetit Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Some perf impact due do the added reflection step to check attributes on constructor parameters. The result of ActivatorUtilities.CreateFactory is typically only called once per type and then cached by the application, so it should not have an impact too big.
I see @steveharter has reviewed this so I trust he's weighed in on the perf risk. I see our benchmarks also treat CreateFactory as something called once: /~https://github.com/dotnet/performance/blob/6cf8107895d5374c21983dd7ad09f711b389f247/src/benchmarks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs#L54-L57
Both the reflection and Linq.Expressions implementations of CreateFactory are already very heavy -> so I agree that this is a low risk.
Approved as this is a blocking issue in a new 8.0 feature. @artl93 please review.
artl93
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Backport of #92082 to release/8.0
Fixes #92076
/cc @benjaminpetit
Customer Impact
Without this fix, keyed DI does not work when using
ActivatorUtilities.CreateFactory. This impact notably MVC and SignalR, and make it impossible to use keyed DI in controller and hub constructors.Testing
Test cases added in this PR, and also manually tested that the fix works in MVC.
Risk
Some perf impact due do the added reflection step to check attributes on constructor parameters. The result of
ActivatorUtilities.CreateFactoryis typically only called once per type and then cached by the application, so it should not have an impact too big.If the attribute doesn't exist, the existing logic should not have changed.