[release/8.0] Arm64: Pass the small size accurately to emitIns_valid_imm_for_ldst_offset #92041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #91741 to release/8.0 /cc @kunalspathak Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@dotnet/jit-contrib @BruceForstall |
BruceForstall
approved these changes
Sep 14, 2023
jeffschwMSFT
approved these changes
Sep 14, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91741 to release/8.0
/cc @kunalspathak
Customer Impact
We sometimes end up choosing a wrong encoding for instruction that needs to load byte/short from memory. This might lead to bad code generated and wrong functional output.
Testing
Manually verified the failing test case and clean CI.
Risk
Low because this scenario happens where frame is larger than usual mostly during OSR when we are trying to load byte/short from tier-0 stack frame.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.