-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][ios] Call mono_gc_init_finalizer_thread to allow gc thread creation #91785
Conversation
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos Issue DetailsThis PR modifies the Fixes #90012
|
/azp run runtime-ioslike |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please verify that the GC dump tests now runs on iOS/tvOS devices on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The test has executed successfully https://helix.dot.net/api/jobs/831b21f1-4098-4f60-a174-033d11d5c3cf/workitems/tracing_eventpipe?api-version=2019-06-17. |
This PR modifies the
runtime.m
Apple template to call themono_gc_init_finalizer_thread
. This function enables the creation of the finalizer thread. If the runtime is compiled with the lazy gc thread creation flag, embedders must call this function to initiate the finalizer. Otherwise, the function does nothing and the runtime creates the finalizer thread automatically.Fixes #90012