Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CoreCLR community platforms to build with the global build template #91646

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Move CoreCLR community platforms to build with the global build template #91646

merged 4 commits into from
Sep 7, 2023

Conversation

jkoritzinsky
Copy link
Member

This makes our community-supported platform testing story consistent (we do all testing of community-supported targets in the runtime-community pipeline and none in the runtime pipeline) and allows us to remove more custom code from the CoreCLR build-job.yml file.

Alternatively, we could keep running these legs in the runtime.yml file and just do the move to the global-build-job template.

@jkoritzinsky
Move CoreCLR community platforms to build in the runtime-community CI…
2a3ea48 
… leg.

This makes our community-supported platform testing story consistent (we do all testing of community-supported targets in the runtime-community pipeline and none in the runtime pipeline) and allows us to remove more custom code from the CoreCLR build-job.yml file.
@jkoritzinsky jkoritzinsky requested review from jkotas and a team September 5, 2023 22:13
@ghost
Copy link

ghost commented Sep 5, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes our community-supported platform testing story consistent (we do all testing of community-supported targets in the runtime-community pipeline and none in the runtime pipeline) and allows us to remove more custom code from the CoreCLR build-job.yml file.

Alternatively, we could keep running these legs in the runtime.yml file and just do the move to the global-build-job template.

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure
Milestone: -

@ghost ghost assigned jkoritzinsky Sep 5, 2023
@jkoritzinsky
Copy link
Member Author

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Sep 6, 2023 •
edited
Loading

runtime-community is optional pipeline for targets that are too expensive and/or too flaky to run unconditionally. It includes tests.

We have build for linux-x86 and linux-armel in the unconditional pipeline to catch the trivial linux-x86 and linux-armel build breaks. The idea is that the build-only leg for linux-x86 and linux-armel is cheap enough and reliable enough to make it worth run unconditionally - it saves us from having to deal with the boring "fix build break" PRs.

@jkoritzinsky
Copy link
Member Author

Sounds good 👍
I'll move these jobs back into the runtime pipeline.

@build-analysis build-analysis bot mentioned this pull request Sep 6, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Sep 6, 2023
Closed
@jkoritzinsky jkoritzinsky changed the title Move CoreCLR community platforms to build in the runtime-community CI leg Move CoreCLR community platforms to build with the global build template Sep 6, 2023
@jkoritzinsky jkoritzinsky marked this pull request as ready for review September 6, 2023 22:24
@jkoritzinsky
Copy link
Member Author

Jobs have been moved back into the runtime pipeline and fixed to pass.

@jkoritzinsky jkoritzinsky requested a review from a team September 6, 2023 22:25
trylek
trylek approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jeremy!

clamp03
clamp03 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@clamp03 clamp03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

wscho77
wscho77 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@wscho77 wscho77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@jkoritzinsky jkoritzinsky mentioned this pull request Sep 7, 2023
Closed
@jkoritzinsky
Copy link
Member Author

Failures are all known.

@jkoritzinsky jkoritzinsky merged commit 17b60e3 into dotnet:main Sep 7, 2023
@jkoritzinsky jkoritzinsky deleted the coreclr-community branch September 7, 2023 00:06
@build-analysis build-analysis bot mentioned this pull request Sep 7, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

@BruceForstall BruceForstall BruceForstall approved these changes

@clamp03 clamp03 clamp03 approved these changes

@wscho77 wscho77 wscho77 approved these changes

@jkotas jkotas Awaiting requested review from jkotas

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jkoritzinsky @jkotas @wscho77 @clamp03 @BruceForstall @trylek