Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][jit] Enable all X86Base intrinsics #91393

Merged
merged 10 commits into from
Sep 8, 2023
Merged

[mono][jit] Enable all X86Base intrinsics #91393

merged 10 commits into from
Sep 8, 2023

Conversation

jandupej
Copy link
Member

@jandupej jandupej commented Aug 31, 2023 •
edited
Loading

Support for System.Runtime.Intrinsics.X86.DivRem is added here. This should mirror CoreCLR's #66551 and address #82195.

EDIT: This also adds support for DivRem on LLVM, as well as BitScanForward and BitScanReverse on mini.

@jandupej jandupej added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-Codegen-JIT-mono labels Aug 31, 2023
@jandupej jandupej added this to the 9.0.0 milestone Aug 31, 2023
@jandupej jandupej self-assigned this Aug 31, 2023
@huoyaoyuan
Copy link
Member

After this is done, I can finish the refine of decimal calculator.

@build-analysis build-analysis bot mentioned this pull request Aug 31, 2023
Closed
@jandupej jandupej changed the title [mono][jit] Support for DivRem intrinsic on x86-64. [mono][jit] Enable all X86Base intrinsics Sep 5, 2023
@jandupej jandupej removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Sep 5, 2023
@jandupej jandupej marked this pull request as ready for review September 5, 2023 15:13
@build-analysis build-analysis bot mentioned this pull request Sep 5, 2023
Closed
@jandupej jandupej mentioned this pull request Sep 6, 2023
Open
@build-analysis build-analysis bot mentioned this pull request Sep 7, 2023
Closed
@jandupej
Copy link
Member Author

jandupej commented Sep 7, 2023

All CI failures are known issues unrelated to this PR.

This was referenced Sep 7, 2023
Open
Open
fanyang-mono
fanyang-mono approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jandupej
Copy link
Member Author

jandupej commented Sep 8, 2023

Got an occurrence of #90458

@jandupej jandupej mentioned this pull request Sep 8, 2023
Open
@jandupej jandupej merged commit a974719 into dotnet:main Sep 8, 2023
@jandupej jandupej deleted the x86-divrem branch September 8, 2023 08:55
@SamMonoRT SamMonoRT mentioned this pull request Sep 9, 2023
Merged
@kotlarmilos kotlarmilos mentioned this pull request Sep 13, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vargaz vargaz vargaz left review comments

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@jandupej jandupej

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jandupej @huoyaoyuan @vargaz @fanyang-mono