Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent #91160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsSee PR #91138 for alternative approach. Report
|
| Author: | filipnavara |
|---|---|
| Assignees: | - |
| Labels: |
|
| Milestone: | - |
This was referenced Aug 26, 2023
dotMorten
reviewed
Aug 26, 2023
| Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM); | ||
|
|
||
| if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials || | ||
| string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) || |
There was a problem hiding this comment.
I think this should be an && between username and password.
There was a problem hiding this comment.
It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
There was a problem hiding this comment.
it's not? I've seen services that only require password with empty username.
There was a problem hiding this comment.
I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
filipnavara
force-pushed
the
nego-no-pnse-alt
branch
from
4850719 to
fd2af56
Compare
…ionPal implementation for NTLM w/ default credentials. This was handled inconsistently between the managed NTLM implementation and the GSSAPI one. Add test for the behavior. Add test to ensure SocketsHttpHandler using CredentialCache.DefaultCredentials with NTLM doesn't throw PNSE exception and returns the Unauthorized HTTP response instead.
filipnavara
force-pushed
the
nego-no-pnse-alt
branch
from
fd2af56 to
f2d7525
Compare
filipnavara
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #91138 for alternative approach.Report
UnknownCredentialsstatus on Unix/Managed NegotiateAuthenticationPal implementation for NTLM w/ default credentialsthrowingcommunicating back withPlatformNotSupportedExceptionwith a useful message that explains which parameters are unsupportedNegotiateAuthenticationStatusCode.UnknownCredentials.SocketsHttpHandler
CredentialCache.DefaultCredentialswith NTLM doesn't throw PNSE exception and returns theUnauthorizedHTTP response instead.Fixes #91131