[release/8.0] Use reader/writer lock instead of mutex for ComWrappers RCW cache
#91149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AaronRobinsonMSFT
added
the
Servicing-consider
|
/cc @manodasanW |
jeffschwMSFT
approved these changes
Aug 26, 2023
jeffschwMSFT
added
Servicing-approved
AaronRobinsonMSFT
force-pushed
the
backport/pr-91120-to-release/8.0
branch
from
c10fa0f to
1d6302a
Compare
jonwis
reviewed
Aug 26, 2023
|
@jkotas or @jeffschwMSFT The CI is green. Please merge when convenient. |
jkotas
approved these changes
Aug 26, 2023
AaronRobinsonMSFT
force-pushed
the
backport/pr-91120-to-release/8.0
branch
from
1d6302a to
be49b7b
Compare
AaronRobinsonMSFT
force-pushed
the
backport/pr-91120-to-release/8.0
branch
from
be49b7b to
34f4f0d
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91120 to release/8.0
/cc @AaronRobinsonMSFT
Customer Impact
User reported issue - #90964. This was observed in a C#/WinRT scenario and would help adoption for other WinRT users.
Testing
We have extensive testing for this scenario and for the performance issue, we've added dotnet/performance#3298.
See #91120 (comment) for details on lack of NAOT changes.
Risk
Low.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.