Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][infra] Upgrade iOS performance queue to OSX 13 #86574

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

kotlarmilos
Copy link
Member

This PR upgrades iOS performance helix queue to osx.13.amd64.iphone.perf, as the helix queue osx.1015.amd64.iphone.perf is set for estimated removal date of 2023-05-31.

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone May 22, 2023
@kotlarmilos kotlarmilos requested a review from LoopedBard3 May 22, 2023 09:30
@kotlarmilos kotlarmilos self-assigned this May 22, 2023
@ghost
Copy link

ghost commented May 22, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR upgrades iOS performance helix queue to osx.13.amd64.iphone.perf, as the helix queue osx.1015.amd64.iphone.perf is set for estimated removal date of 2023-05-31.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@LoopedBard3
Copy link
Member

The work for getting the queues updated to MacOS 13 is still in progress. The removal date is going to be updated to reflect this still being in progress and not complete yet. As such, I don't think we should merge this change in yet, but keep it for once the queues are updated.

@kotlarmilos kotlarmilos added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 23, 2023
@kotlarmilos
Copy link
Member Author

According to the service rollout, it should be updated during the day, so we could switch to the new version.

@kotlarmilos kotlarmilos removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 31, 2023
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the queue is ready now

@kotlarmilos kotlarmilos merged commit da71284 into dotnet:main Jun 19, 2023
@kotlarmilos
Copy link
Member Author

Do we need to backport it to .NET 7 and .NET 6?

@LoopedBard3
Copy link
Member

It looks like the queue is not ready yet, the recent jobs sent to the queue are all waiting and timing out: https://dev.azure.com/dnceng/internal/_build/results?buildId=2204258. We should revert this until either the normal jobs start failing due to the cutover or we have a test run working on the new queue.

kotlarmilos added a commit that referenced this pull request Jun 19, 2023
LoopedBard3 pushed a commit that referenced this pull request Jun 19, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants