Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of Python urllib3 #85915

Merged
merged 1 commit into from
May 8, 2023

Conversation

kotlarmilos
Copy link
Member

This PR should fix the incorrect version of Python urllib3. The performance job reported the following error in https://helixri107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-feature-nativeaot-ib4b90c1a949f4ffaa7/SOD%20-%20iOS%20HelloWorld%20Native%20AOT%20.app/1/console.8ae82658.log?sv=2021-08-06&se=2023-08-06T13%3A15%3A52Z&sr=c&sp=rl&sig=juupMNxFbpsYILd7WCtcWIk347lAXD48i0Lp9szNBYM%3D.

Traceback (most recent call last):
  File "/private/tmp/helix/working/B6DD0A05/w/ABD70978/u/.venv/lib/python3.8/site-packages/azure/core/pipeline/transport/__init__.py", line 73, in __getattr__
    from ._requests_basic import RequestsTransport
  File "/private/tmp/helix/working/B6DD0A05/w/ABD70978/u/.venv/lib/python3.8/site-packages/azure/core/pipeline/transport/_requests_basic.py", line 28, in <module>
    import urllib3
  File "/private/tmp/helix/working/B6DD0A05/w/ABD70978/u/.venv/lib/python3.8/site-packages/urllib3/__init__.py", line 38, in <module>
    raise ImportError(
ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with LibreSSL 2.8.3. See: /~https://github.com/urllib3/urllib3/issues/2168

Reference urllib3/urllib3#2168

@ghost
Copy link

ghost commented May 8, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR should fix the incorrect version of Python urllib3. The performance job reported the following error in https://helixri107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-feature-nativeaot-ib4b90c1a949f4ffaa7/SOD%20-%20iOS%20HelloWorld%20Native%20AOT%20.app/1/console.8ae82658.log?sv=2021-08-06&se=2023-08-06T13%3A15%3A52Z&sr=c&sp=rl&sig=juupMNxFbpsYILd7WCtcWIk347lAXD48i0Lp9szNBYM%3D.

Traceback (most recent call last):
  File "/private/tmp/helix/working/B6DD0A05/w/ABD70978/u/.venv/lib/python3.8/site-packages/azure/core/pipeline/transport/__init__.py", line 73, in __getattr__
    from ._requests_basic import RequestsTransport
  File "/private/tmp/helix/working/B6DD0A05/w/ABD70978/u/.venv/lib/python3.8/site-packages/azure/core/pipeline/transport/_requests_basic.py", line 28, in <module>
    import urllib3
  File "/private/tmp/helix/working/B6DD0A05/w/ABD70978/u/.venv/lib/python3.8/site-packages/urllib3/__init__.py", line 38, in <module>
    raise ImportError(
ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with LibreSSL 2.8.3. See: /~https://github.com/urllib3/urllib3/issues/2168

Reference urllib3/urllib3#2168

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@LoopedBard3 LoopedBard3 merged commit b132963 into dotnet:main May 8, 2023
@kotlarmilos kotlarmilos deleted the bugfix/urllib3-version branch May 8, 2023 19:03
@kotlarmilos kotlarmilos restored the bugfix/urllib3-version branch May 8, 2023 21:33
@kotlarmilos
Copy link
Member Author

@kotlarmilos
Copy link
Member Author

It looks like the commit 5ceda58 has resolved the issue in https://dev.azure.com/dnceng/internal/_build/results?buildId=2176497&view=results.

LoopedBard3 added a commit to LoopedBard3/runtime that referenced this pull request May 9, 2023
@kotlarmilos kotlarmilos deleted the bugfix/urllib3-version branch May 11, 2023 10:38
LoopedBard3 added a commit to LoopedBard3/runtime that referenced this pull request Jun 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants