Allow ResolveReadyToRunCompilers to be run under FreeBSD #84250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
added
the
community-contribution
am11
reviewed
Apr 3, 2023
|
Matching SDK PR (also by @sec ): dotnet/sdk#31581 |
jeffhandley
added
area-ReadyToRun-coreclr
and removed
needs-area-label
|
Is this ready to be reviewed/merged? |
|
Hello @sec, Checking in if this PR is ready to review/merge? |
jkotas
approved these changes
Jun 2, 2023
|
I have pushed a change that incorporates the feedback. @mangod9 PTLA |
This was referenced Jun 2, 2023
|
@jkotas Thanks for doing those changes, I've been sick for last few weeks and now trying to catch up. There's also the same code in dotnet/sdk#31581 - should the changes be done there also? |
|
We can wait for this one to be finalized and merged, and then apply the final changes to the other PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable almost patchless build of runtime under FreeBSD, with R2R. @Thefrank