Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some IAsyncResult implementations from System.Net.Mail #82644

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

stephentoub
Copy link
Member

Whittling away at our remaining APM implementations.

Whittling away at our remaining APM implementations.
@ghost
Copy link

ghost commented Feb 24, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Whittling away at our remaining APM implementations.

Author: stephentoub
Assignees: -
Labels:

area-System.Net

Milestone: -

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Do you plan to do rest of the Mail as well? (at some point)

@stephentoub
Copy link
Member Author

Ideally. The rest is harder and more error-prone, though, so I'm hesitant to attempt it with our current test coverage.

@wfurt
Copy link
Member

wfurt commented Feb 24, 2023

It has been on my wishlist for a long time. Maybe @filipnavara or others can help. We did talk about #19436 specifically but I'm sure there may be more.

@filipnavara
Copy link
Member

It has been on my wishlist for a long time. Maybe @filipnavara or others can help. We did talk about #19436 specifically but I'm sure there may be more.

This one is very low on my list given the fact that the whole library is effectively deprecated. I have some cleanup PRs for System.Net.Security that I would like to resurrect in the .NET 8 timeframe but currently nothing for the Mail libraries.

@stephentoub
Copy link
Member Author

I have some cleanup PRs for System.Net.Security

There aren't any APM implementations remaining there, is there?

@stephentoub stephentoub merged commit e520ccb into dotnet:main Feb 24, 2023
@stephentoub stephentoub deleted the mailbeginend branch February 24, 2023 23:35
@filipnavara
Copy link
Member

filipnavara commented Feb 25, 2023

I have some cleanup PRs for System.Net.Security

There aren't any APM implementations remaining there, is there?

There's NegotiateStream but it already uses the TaskToAsyncResult pattern in all the places IIRC. I didn't mean that my cleanups are specific to APM. Sorry, should have made that clearer.

@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants