Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make revocation tests use CRLBuilder instead of its own copy #72886

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

bartonjs
Copy link
Member

Some test cleanup that got missed in the CRLBuilder PR

@bartonjs bartonjs added area-System.Security test-enhancement Improvements of test source code labels Jul 26, 2022
@bartonjs bartonjs added this to the 7.0.0 milestone Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Some test cleanup that got missed in the CRLBuilder PR

Author: bartonjs
Assignees: -
Labels:

area-System.Security, test-enhancement

Milestone: 7.0.0

@ghost ghost assigned bartonjs Jul 26, 2022
@bartonjs
Copy link
Member Author

I learned not to ctrl+click multiple commits and then choose revert. That only chooses the last one you selected and if it's not the top you get to merge conflict with yourself.

So I just squashed everything down to the one commit and force pushed.

Dear GitHub, I don't know what you're doing when you update the merge status grid/block/whatever, but quit moving my focus to a different textbox.

@vcsjones
Copy link
Member

A tip, in case it wasn't obvious (because it's not), "forced-pushed" is a link:

F7FDC6F3-EEE3-40D1-9A0C-28BC8F7A1DC9

So you can see a diff between the force push references.

Dear GitHub

Noted 🙂

@bartonjs bartonjs merged commit d944592 into dotnet:main Jul 27, 2022
@bartonjs bartonjs deleted the use_crlbuilder branch July 27, 2022 21:41
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants