[release/6.0] Surface error when emcc -version failed.
#103967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Jun 25, 2024
rbhanda
added
Servicing-approved
pavelsavara
approved these changes
Jun 28, 2024
ilonatommy
merged commit 40f8a8d
into
dotnet:release/6.0-staging
112 of 122 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #98714
Partial backport of #61276 to release/6.0-staging
Customer Impact
User will see the details of error thrown by
emcc --versioncommand instead of generalExample of specific message:
Regression
Testing
Build runtime, remove emcc from PATH and observe the error details.
Risk
Low. It runs the version checking twice in case of errors instead of once.