[release/6.0-staging] Fix #103485 #103935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
amanasifkhalid
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
amanasifkhalid
force-pushed
the
fix-103485
branch
from
1efaa5b to
03cf81c
Compare
This was referenced Jun 25, 2024
|
ping @agocke @jkoritzinsky -- test failures are known. Build Analysis seems to be blocked by some infra issues that look unrelated to this change. |
agocke
approved these changes
Jun 27, 2024
|
hoyosjs
approved these changes
Jun 28, 2024
| checkDownloadedFiles: true | ||
| - template: /eng/pipelines/common/templates/global-build-step.yml | ||
| parameters: | ||
| buildArgs: -s linuxdac+alpinedac -c $(_BuildConfig) |
There was a problem hiding this comment.
the only thing is the xdac's used to also be uploaded to the crossDacArtifactsContainer. This is not blocking since they matter the most for PRs and they are there.
jkoritzinsky
approved these changes
Jun 28, 2024
JulieLeeMSFT
approved these changes
Jun 28, 2024
|
CC .@carlossanlop |
amanasifkhalid
merged commit 89447d5
into
dotnet:release/6.0-staging
141 of 155 checks passed
This was referenced Jul 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back jobs for building Linux installers and CrossDAC packages as part of the .NET 6 official build by surgically merging various dependent changes. There are a couple changes unrelated to this work, but otherwise needed to unblock official .NET 6 builds (like upgrading to macOS 12 images). Fixes #103485. Official build
@jkoritzinsky @agocke PTAL; thanks!