Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReversePInvoke transition should be no-op in DoNotTriggerGc region on NativeAOT #85377

Closed
jkoritzinsky opened this issue Apr 26, 2023 · 1 comment · Fixed by #85435
Closed

ReversePInvoke transition should be no-op in DoNotTriggerGc region on NativeAOT #85377

jkoritzinsky opened this issue Apr 26, 2023 · 1 comment · Fixed by #85435
Assignees
@VSadov
Labels
area-NativeAOT-coreclr
Milestone
8.0.0

Comments

@jkoritzinsky
Copy link
Member

The ReversePInvoke transition should be no-op in DoNotTriggerGc region. The whole purpose of DoNotTriggerGc regions is to turn the ReversePInvoke transition into no-op that is not quite happening here.

Originally posted by @jkotas in #85235 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 26, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 26, 2023
@jkoritzinsky jkoritzinsky mentioned this issue Apr 26, 2023
Merged
@jkoritzinsky jkoritzinsky added area-NativeAOT-coreclr and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 26, 2023
@jkoritzinsky jkoritzinsky added this to the 8.0.0 milestone Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

The ReversePInvoke transition should be no-op in DoNotTriggerGc region. The whole purpose of DoNotTriggerGc regions is to turn the ReversePInvoke transition into no-op that is not quite happening here.

Originally posted by @jkotas in #85235 (comment)

Author: jkoritzinsky
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

jkotas added a commit to jkotas/runtime that referenced this issue Apr 26, 2023
@jkotas
Try to repro dotnet#85377 in CI
d8acbb5
@VSadov VSadov self-assigned this Apr 26, 2023
@VSadov VSadov mentioned this issue Apr 27, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 27, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 28, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@VSadov VSadov

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
8.0.0
2 participants
@jkoritzinsky @VSadov