Track EA APIs #64487
Merged
Track EA APIs #64487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the latest prerelease of our analyzers, which include the ability to track `internal` APIs. We will now track the APIs we ship via our EA packages, much like we do with our regular Public APIs. This will hopefully alert us to accidental refactorings that will break an insertion, or remind us to ensure that changes that need a dual insertion are known about ahead of time.
|
@sharwell @dotnet/roslyn-infrastructure for reviews please. |
mavasani
approved these changes
Oct 6, 2022
sharwell
reviewed
Oct 10, 2022
Comment on lines
22
to
23
| [Obsolete("Call overload that takes a CancellationToken", error: false)] | ||
| #pragma warning disable RS0060 // API with optional parameter(s) should have the most parameters amongst its public overloads |
There was a problem hiding this comment.
💡 These two lines should be reversed if the #pragma warning is used for a group of methods
sharwell
approved these changes
Oct 10, 2022
333fred
commented
Oct 10, 2022
src/Tools/ExternalAccess/FSharp/Navigation/IFSharpDocumentNavigationService.cs
Outdated
Show resolved
Hide resolved
* upstream/main: (252 commits) Use the source-built version of ref packs and don't use app host when building in source-build (dotnet#64055) Enable rich LSIF hover information. (dotnet#64580) Add ChecksumAlgorithm to project snapshot (dotnet#62840) Utility for uploading artifact on test failure (dotnet#64578) Enable diagnostics Revert "Remove unused TS brace completion code" Publish additional packages to vssdk feed (dotnet#64571) spelling Move check Simplify SymbolKey implementation lint Update publish data to test PR validation fix (dotnet#64559) Simplify Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/SymbolKey/SymbolKey.cs Lint Proper equality checks Update src/Workspaces/Remote/Core/RemoteCallback.cs Revert "Not wait for solution crawler because it can be very busy" Add and use TargetFramework.Net70 (dotnet#64490) Not wait for solution crawler because it can be very busy ...
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest prerelease of our analyzers, which include the ability to track
internalAPIs. We will now track the APIs we ship via our EA packages, much like we do with our regular Public APIs. This will hopefully alert us to accidental refactorings that will break an insertion, or remind us to ensure that changes that need a dual insertion are known about ahead of time.