-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IDE2xxx experimental rules #6353
Enable IDE2xxx experimental rules #6353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the dotnet_diagnostic entries added in the PR are unnecessary and can be removed.
Fix all in Solution for IDE2003 invoked from C# source didn't fix any VB violations. So I needed to run the FixAll twice (once for each language). Is that expected? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6353 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 1362 1360 -2
Lines 315490 315522 +32
Branches 10187 10187
=======================================
+ Hits 303137 303173 +36
+ Misses 9920 9917 -3
+ Partials 2433 2432 -1 |
Yes that is expected |
Fixes #3892