Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IDE2xxx experimental rules #6353

Merged
merged 10 commits into from
Dec 15, 2022

Conversation

Youssef1313
Copy link
Member

Fixes #3892

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 14, 2022 20:20
@Youssef1313 Youssef1313 changed the title Enable ide experimental rules Enable IDE2xxx experimental rules Dec 14, 2022
.editorconfig Outdated Show resolved Hide resolved
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think the dotnet_diagnostic entries added in the PR are unnecessary and can be removed.

@Youssef1313
Copy link
Member Author

Fix all in Solution for IDE2003 invoked from C# source didn't fix any VB violations. So I needed to run the FixAll twice (once for each language).

Is that expected?

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #6353 (9e92aa9) into main (37c910d) will increase coverage by 0.00%.
The diff coverage is 95.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6353   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files        1362     1360    -2     
  Lines      315490   315522   +32     
  Branches    10187    10187           
=======================================
+ Hits       303137   303173   +36     
+ Misses       9920     9917    -3     
+ Partials     2433     2432    -1     

@mavasani
Copy link
Contributor

Fix all in Solution for IDE2003 invoked from C# source didn't fix any VB violations. So I needed to run the FixAll twice (once for each language).

Is that expected?

Yes that is expected

@mavasani mavasani merged commit ea8aa10 into dotnet:main Dec 15, 2022
@github-actions github-actions bot added this to the vNext milestone Dec 15, 2022
@Youssef1313 Youssef1313 deleted the enable-ide-experimental-rules branch December 15, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling RS0100 on this repo
2 participants