Fix PublicAPI enablement checks #6291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic was broken for projects that only have public or only have internal APIs. I refactored the registration logic to run completely separately for both public and internal to fix this.
|
Recommended review with whitespace off. |
333fred
force-pushed
the
fix-api-analyzer
branch
from
09a0c51 to
1a7266a
Compare
jcouv
reviewed
Nov 29, 2022
jcouv
reviewed
Nov 29, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6291 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 1364 1364
Lines 313717 313730 +13
Branches 10125 10125
=======================================
+ Hits 301357 301374 +17
- Misses 9939 9940 +1
+ Partials 2421 2416 -5 |
|
@jcouv please take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic was broken for projects that only have public or only have internal APIs. I refactored the registration logic to run completely separately for both public and internal to fix this.