Don't suppress exit codes Appium driver install #27024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- eng/scripts/appium-install.ps1: Language not supported
jsuarezruiz
approved these changes
Jan 10, 2025
|
Failing test unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For some reason the exit codes were reset on the
appium driver doctorcalls. If the drivers are not installed correctly, the tests will fail so we want to fail early and not let the whole pipeline go through when this happens.This PR removes the suppressing of the exit codes for these calls so that the pipeline should fail whenever the one of the drivers fails to install.
Additionally, this PR makes changes in how the JAVA_HOME variable is set. For macOS, this step always seemed to fail as can be seen here
This needed to be fixed so that the
appium driver doctorcalls do not report the unset JAVA_HOME variable as an error.Issues Fixed
Fixes #27013