[Testing] Enabling ported UITests from Xamarin.UITests to Appium - 59 #26731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
anandhan-rajagopal
added
area-testing
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (5)
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla43519.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla45702.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla46458.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla42277.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla39636.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla39821.cs:22
- The change from App.WaitForNoElement("Success", timeout: TimeSpan.FromSeconds(25)) to App.WaitForElement("Success") significantly alters the test logic. Ensure this change is intentional and covered by tests.
App.WaitForElement("Success");
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla39702.cs:25
- The removal of await Task.Delay(4000); could potentially affect the test timing. Verify if this change is intended.
App.EnterText(TheEntry, Success);
rmarinho
approved these changes
Dec 20, 2024
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 59th group of tests enabled.
TestCases